Add max length validation for app name in V3 API#4928
Merged
philippthun merged 1 commit intocloudfoundry:mainfrom Mar 17, 2026
Merged
Add max length validation for app name in V3 API#4928philippthun merged 1 commit intocloudfoundry:mainfrom
philippthun merged 1 commit intocloudfoundry:mainfrom
Conversation
When creating or updating an app with a name exceeding 255 characters, the database would raise a constraint violation error that was not caught, resulting in an unhelpful "UnknownError" (code 10001) response. This adds explicit length validation to AppCreateMessage and AppUpdateMessage to provide a meaningful error message before the request reaches the database layer. - Add length validation (max 255 chars) to AppCreateMessage - Add length validation (max 255 chars) to AppUpdateMessage - Add corresponding unit tests for both messages
sethboyles
approved these changes
Mar 16, 2026
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Mar 17, 2026
Changes in cloud_controller_ng:
- Add max length validation for app name in V3 API
PR: cloudfoundry/cloud_controller_ng#4928
Author: Rashed K <89036140+rashedkvm@users.noreply.github.com>
Dependency updates in cloud_controller_ng:
- build(deps): bump net-ssh from 7.3.0 to 7.3.1
PR: cloudfoundry/cloud_controller_ng#4925
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Mar 17, 2026
Changes in cloud_controller_ng:
- Inline Allowy gem
PR: cloudfoundry/cloud_controller_ng#4926
Author: Johannes Haass <johannes.haass@sap.com>
- Add max length validation for app name in V3 API
PR: cloudfoundry/cloud_controller_ng#4928
Author: Rashed K <89036140+rashedkvm@users.noreply.github.com>
Dependency updates in cloud_controller_ng:
- build(deps): bump net-ssh from 7.3.0 to 7.3.1
PR: cloudfoundry/cloud_controller_ng#4925
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
A short explanation of the proposed change:
When creating or updating an app with a name exceeding 255 characters, the database would raise a constraint violation error that was not caught, resulting in an unhelpful "UnknownError" (code 10001) response.
An explanation of the use cases your change solves
This adds explicit length validation to AppCreateMessage and AppUpdateMessage to provide a meaningful error message before the request reaches the database layer.
Links to any other associated PRs
Fixes Pushing an application with a name over 255 characters results in unknown error #4927
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests